flua: make the ucl module a dynamic module
ClosedPublic
Actions

Authored by bapt on Sep 6 2024, 3:16 PM.

Details

Reviewers

markj
kevans
imp

Commits

rGbb2d016afb00: flua: make the ucl module a dynamic module

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59355
Build 56242: arc lint + arc unit

Event Timeline

bapt created this revision.Sep 6 2024, 3:16 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 6 2024, 3:16 PM

bapt requested review of this revision.Sep 6 2024, 3:16 PM

Harbormaster completed remote builds in B59355: Diff 143040.Sep 6 2024, 3:16 PM

bapt added reviewers: markj, kevans, imp.Sep 6 2024, 3:17 PM

Looks ok to me. It'd be nice to raise WARNS further but I don't know where the problems are.

This revision is now accepted and ready to land.Sep 6 2024, 3:20 PM

It's not used by the boot loader, nor do I think it likely to be added, so this is fine. It will just demand load for those that want it so it makes sense to me. It's also quite unlikely to be used in the sysent case at least not without a wholesale redo of the syscall tables ..

Closed by commit rGbb2d016afb00: flua: make the ucl module a dynamic module (authored by bapt). · Explain WhySep 6 2024, 3:25 PM

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rGbb2d016afb00: flua: make the ucl module a dynamic module.