sound: Re-arrange vchan_setnew() initial checks and improve errno values
ClosedPublic
Actions

Authored by christos on Sep 6 2024, 10:54 AM.

Tags

None

Referenced Files

	F102931296: D46560.diff
	Mon, Nov 18, 9:51 PM

	F102879691: D46560.id143016.diff
	Mon, Nov 18, 9:01 AM

	Unknown Object (File)
	Sun, Oct 27, 2:02 AM

	Unknown Object (File)
	Oct 16 2024, 11:48 PM

	Unknown Object (File)
	Sep 26 2024, 12:47 PM

	Unknown Object (File)
	Sep 25 2024, 7:41 PM

	Unknown Object (File)
	Sep 22 2024, 8:09 PM

	Unknown Object (File)
	Sep 22 2024, 2:16 PM

View All 18 Files

Subscribers

imp

Details

Reviewers

markj
emaste
dev_submerge.ch

Summary

Check newcnt first since there is no reason to continue if we provided
an invalid newcnt value. Also return more helpful errno values.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59336
Build 56223: arc lint + arc unit

Event Timeline

christos created this revision.Sep 6 2024, 10:54 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 6 2024, 10:54 AM

christos requested review of this revision.Sep 6 2024, 10:54 AM

Harbormaster completed remote builds in B59336: Diff 143016.Sep 6 2024, 10:54 AM

christos retitled this revision from sound: Re-arrange initial checks and improve errno values to sound: Re-arrange vchan_setnew() initial checks and improve errno values.Sep 6 2024, 10:54 AM

dev_submerge.ch accepted this revision.Sep 13 2024, 7:56 PM

This revision is now accepted and ready to land.Sep 13 2024, 7:56 PM

christos closed this revision.Oct 19 2024, 11:41 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

vchan.c

8 lines

Diff 143016

View Options

sound: Re-arrange vchan_setnew() initial checks and improve errno valuesClosedPublicActions