This test case verifies that grep detects symlink loops when traversing
a directory hierarchy.
Fixes: fc12c191c087 ("grep: Default to -p instead of -S.")
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 59313 Build 56200: arc lint + arc unit
Event Timeline
Comment Actions
Would it make sense to create another testcase specific for -S vs non--S?
Not a huge deal.. just thinking ahead (and yes, I need to rebase netbsd-tests sometime soon...).
| contrib/netbsd-tests/usr.bin/grep/t_grep.sh | ||
|---|---|---|
| 75 | Note that the old test wouldn't have passed with most other grep's either FWIW including BSD grep on macOS. I actually had created a directory tree with various helps and symlinks (including broken symlinks) for my own local testing. I then tested all of -p, -S, and -O against the tree. I documented much of this in the PR and in the review. Should maybe add those tests, but they aren't NetBSD tests at that point. I guess they could go in a grep/tests/ directory in the tree? | |
| contrib/netbsd-tests/usr.bin/grep/t_grep.sh | ||
|---|---|---|
| 75 | Indeed, I think I can remove this FreeBSD block. There is already a usr.bin/grep/tests/grep_freebsd_test.sh, which seems like a good place for your tests to live. | |