Page MenuHomeFreeBSD

vmm: Use make_dev_s() to create vmm devices
ClosedPublic

Authored by markj on Aug 30 2024, 2:41 PM.
Tags
None
Referenced Files
F115644718: D46488.diff
Sat, Apr 26, 11:48 AM
Unknown Object (File)
Wed, Apr 23, 6:08 PM
Unknown Object (File)
Sat, Apr 19, 4:18 AM
Unknown Object (File)
Mar 19 2025, 8:52 PM
Unknown Object (File)
Feb 21 2025, 8:24 PM
Unknown Object (File)
Feb 19 2025, 11:27 PM
Unknown Object (File)
Feb 11 2025, 8:18 AM
Unknown Object (File)
Feb 5 2025, 9:59 PM
Subscribers

Details

Summary

This avoids creating windows where a device file is accessible but the
device-specific field is not set.

Now that vmmdev_mtx is a sleepable lock, avoid dropping it while
creating devices files. This makes it easier to handle races and
simplifies some code; for example, the VSC_LINKED flag is no longer
needed.

Suggested by: jhb

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59245
Build 56132: arc lint + arc unit

Event Timeline

jhb added a subscriber: jhb.

Hmm, so nothing was checking for si_drv1 being NULL in the cdevsw methods? Oof.

This revision is now accepted and ready to land.Aug 30 2024, 3:41 PM

Yikes indeed! Nice catch. It likely was usually fine, but yikes!

This revision was automatically updated to reflect the committed changes.