Page MenuHomeFreeBSD
Differential D46476

src.conf: Add a MK_ZFS_TESTS knob
ClosedPublic
Actions

Authored by markj on Thu, Aug 29, 2:39 PM.
Tags
None
Referenced Files
F97299963: D46476.diff
Sat, Sep 28, 1:28 PM
Unknown Object (File)
Fri, Sep 13, 5:40 AM
Unknown Object (File)
Wed, Sep 11, 1:11 AM
Unknown Object (File)
Sun, Sep 8, 10:26 AM
Unknown Object (File)
Sun, Sep 8, 10:24 AM
Unknown Object (File)
Sun, Sep 8, 10:23 AM
Unknown Object (File)
Sun, Sep 8, 10:23 AM
Unknown Object (File)
Sun, Sep 8, 10:23 AM
View All 21 Files
Subscribers
bdrewery
imp

Details

Reviewers
asomers
emaste
Commits
rG20191b71bae1: src.conf: Add a MK_ZFS_TESTS knob
rG24affded3d4e: src.conf: Add a MK_ZFS_TESTS knob
Summary

The in-tree ZFS test suite is somewhat outdated and I see a number of
failures there. I tend to think that we want to integrate the OpenZFS
test suite somehow, replacing the legacy one, though it's also possible
to run that as a separate test suite.

In any case, if one wants to run the OpenZFS test suite separately, it's
useful to be able to disable installation of the legacy ZFS test suite,
so let's provide a src.conf option to do that.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59229
Build 56116: arc lint + arc unit

Event Timeline

markj created this revision.Thu, Aug 29, 2:39 PM
Herald added subscribers: imp, bdrewery. · View Herald TranscriptThu, Aug 29, 2:39 PM
markj requested review of this revision.Thu, Aug 29, 2:39 PM
Harbormaster completed remote builds in B59227: Diff 142591.Thu, Aug 29, 2:39 PM
emaste added inline comments.Thu, Aug 29, 2:49 PM
tools/build/options/WITHOUT_ZFS
9–10 ↗(On Diff #142591)

This text should be generated automatically by makeman

markj updated this revision to Diff 142595.Thu, Aug 29, 2:55 PM

Remove an unneeded doc update.

Harbormaster completed remote builds in B59229: Diff 142595.Thu, Aug 29, 2:55 PM
markj marked an inline comment as done.Thu, Aug 29, 2:56 PM
markj added a comment.Fri, Aug 30, 3:55 PM

it's useful to be able to disable installation of the legacy ZFS test suite

One other reason it's useful is to save time - the ZFS tests take a very long time to run when the kernel is compiled with sanitizers enabled.

markj added a comment.Fri, Sep 6, 1:33 PM

Any objections to this? I'd like to have a separate discussion about the future of the "legacy" test suite versus OpenZFS' test suite, but this option is useful to me regardless.

asomers accepted this revision.Fri, Sep 6, 1:50 PM

This seems reasonable. Jenkins already disables the ZFS tests for normal runs.

This revision is now accepted and ready to land.Fri, Sep 6, 1:50 PM
Closed by commit rG24affded3d4e: src.conf: Add a MK_ZFS_TESTS knob (authored by markj). · Explain WhySat, Sep 7, 2:46 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG24affded3d4e: src.conf: Add a MK_ZFS_TESTS knob.
markj added a commit: rG20191b71bae1: src.conf: Add a MK_ZFS_TESTS knob.Fri, Sep 20, 11:40 AM

Revision Contents
Changeset List

PathSize
share/
mk/
6 lines
tests/
sys/
cddl/
2 lines
tools/
build/
options/
1 line

Diff 142595

View Options

share/mk/src.opts.mk

Loading...
View Options

tests/sys/cddl/Makefile

Loading...
View Options

tools/build/options/WITHOUT_ZFS_TESTS

Loading...