sound examples: Simplify MIDI example

[christos]

Summary

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

[emaste]

Commit message should include some more detail (e.g. explain that it's not really OSS) and will need an ObsoleteFiles.inc update for the now-removed ossmidi.h.

[christos]

In D46306#1056039, @emaste wrote:

Commit message should include some more detail (e.g. explain that it's not really OSS) and will need an ObsoleteFiles.inc update for the now-removed ossmidi.h.

I will combine D46308 with this and update ObsoleteFiles.inc. Updating the diff in a few mins.

[emaste]

It might be better to keep the move & rewrite as separate commits so it's clear to git that it's the same file (rather than inferring this from delete + new file that are similar); if you do keep them separate I don't have a strong opinion on move-then-edit or edit-then-move.

[christos]

In D46306#1056044, @emaste wrote:

It might be better to keep the move & rewrite as separate commits so it's clear to git that it's the same file (rather than inferring this from delete + new file that are similar); if you do keep them separate I don't have a strong opinion on move-then-edit or edit-then-move.

Alright. Regarding the commit message I mention that this code is not OSS related in the other patch, which is the one that actually moves it out of oss/.

[christos]

Add ossmidi.h remove to ObsoleteFiles.inc.

[dev_submerge.ch]

share/examples/sound/oss/midi.c

54

Shouldn't this be

read(fd, &raw, sizeof(raw)) < sizeof(raw)

according to read(2)?

See also similar lines below.

[christos]

Make reads more robust.

[christos]

share/examples/sound/oss/midi.c

54

Can also be for more robustness.

[christos]

Bump.