Not to hijack, but to boost the thread I am uploading this patch rebased on the most recent CURRENT. Perhaps a wider audience will find it also useful as I found this patch by Peter Eriksson. Thank you for sharing your work Peter !
Details
- Reviewers
- None
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Not to hijack, but to boost the thread I am uploading this patch rebased on the most recent CURRENT. Perhaps a wider audience will find it also useful as I found to. The original patch by Peter Eriksson submitted to review D25155
Thank you for sharing your work Peter !
So... This wasn't committed before because it intermixed the verbosity changes and the other changes.
The maintainer of CISS at the time demured on that aspect of it, but had already started to disengage from the community so wasn't good about communicating that.
Please separate the two sets out. It will be needed to upstream anyway. Since you've started a new review, I'd suggest removing the verbosity ones from this one and creating a new one. (or if you are more comfortable, moving to a github pull request where we can look at both at the same time, and you can also have two commits).
Also, there's no enough context here. Please re-upload with -U99999 if you decide to continue here and not as a pull request.
The other reason I didn't commit this before was that I had no CISS hardware to test with, and my line on getting that dried up. I also don't think I have any disks to test with, but I may be mistaken about that detail.
It would also be useful to know when receive diagnostic commands are sent/received and why we're justified adding them to that list. But given the history of this, we might not get that detail.
The original review D25155 (https://reviews.freebsd.org/D25155) has been committed in rGf03e1a42e92e: ciss: Minor formatting nit. (authored by pen_lysator.liu.se, committed by imp https://reviews.freebsd.org/rGf03e1a42e92eff76dcf474655b600db37b04ae2b)
If there's anything else that needs to be done, or if I botched something in the merge, please let me know.