Add smbus and i2c device id for Meteor Lake
ClosedPublic
Actions

Values obtained from pciconf by aokblast on Framework 13 Intel Core Ultra 1 (165H).
With these changes I2C can work, so we can use the I2C touchpad driver instead of PS2 emulation.
It will also enable function buttons that are handled by I2C HID Consumer Control.

Add extra id for smbus

Harbormaster completed remote builds in B58974: Diff 141943.Aug 9 2024, 8:34 AM

aokblast edited the summary of this revision. (Show Details)Aug 9 2024, 8:35 AM

aokblast added reviewers: jhb, emaste.Aug 9 2024, 8:38 AM

emaste added inline comments.Aug 11 2024, 7:01 PM

sys/dev/ichiic/ig4_pci.c
171–174	the other lines use tab before the value
sys/dev/ichsmb/ichsmb_pci.c
116–118	other lines in this block use tabs

LGTM other than the whitespace consistency with the other lines

Comply with space style

Harbormaster completed remote builds in B58993: Diff 142014.Aug 12 2024, 2:25 PM

Fix it

emaste accepted this revision.Aug 12 2024, 2:30 PM

This revision is now accepted and ready to land.Aug 12 2024, 2:30 PM

Also successfully tested on our system with 125H:

> dmesg | grep -e hid -e smbus
smbus0: <System Management Bus> on ichsmb0
iichid0: <FRMW0005:08 32AC:001B I2C HID device> at addr 0x51 on iicbus15
iichid0: Using sampling mode
hidbus0: <HID bus> on iichid0
iichid1: <FRMW0004:07 32AC:0006 I2C HID device> at addr 0x50 on iicbus15
iichid1: Using sampling mode
hidbus1: <HID bus> on iichid1
iichid2: <PIXA3854:06 093A:0274 I2C HID device> at addr 0x2c on iicbus17
iichid2: Using sampling mode
hidbus2: <HID bus> on iichid2
hcons0: <FRMW0004:07 32AC:0006 Consumer Control> on hidbus1
hms0: <PIXA3854:06 093A:0274 Mouse> on hidbus2
hmt0: <PIXA3854:06 093A:0274 TouchPad> on hidbus2
hconf0: <PIXA3854:06 093A:0274 Configuration> on hidbus2

Closed by commit rGd3b05d0ea10a: Add smbus and i2c device IDs for Meteor Lake (authored by aokblast, committed by lwhsu). · Explain WhyAug 13 2024, 12:56 PM

This revision was automatically updated to reflect the committed changes.

lwhsu added a commit: rGd3b05d0ea10a: Add smbus and i2c device IDs for Meteor Lake.

emaste added a commit: rG14c22e28e4ee: Add smbus and i2c device IDs for Meteor Lake.Thu, Oct 17, 4:33 PM