Page MenuHomeFreeBSD
Differential D46220

mixer.3: Fix mixer_get_mode() description
ClosedPublic
Actions

Authored by christos on Aug 4 2024, 1:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 4:21 AM
Unknown Object (File)
Sep 30 2024, 3:31 PM
Unknown Object (File)
Sep 30 2024, 3:15 PM
Unknown Object (File)
Sep 20 2024, 4:10 AM
Unknown Object (File)
Sep 16 2024, 3:08 PM
Unknown Object (File)
Aug 31 2024, 7:46 AM
Unknown Object (File)
Aug 24 2024, 2:18 PM
Unknown Object (File)
Aug 8 2024, 4:55 PM
View All 10 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rGdb238c7c52b3: mixer.3: Fix mixer_get_mode() description
rG6e744de1a3dc: mixer.3: Fix mixer_get_mode() description
Summary

Improve wording and also fix the constants' names.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58937
Build 55824: arc lint + arc unit

Event Timeline

christos created this revision.Aug 4 2024, 1:28 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 4 2024, 1:28 PM
christos requested review of this revision.Aug 4 2024, 1:28 PM
Harbormaster completed remote builds in B58936: Diff 141803.Aug 4 2024, 1:28 PM
dev_submerge.ch added inline comments.Aug 4 2024, 1:39 PM
lib/libmixer/mixer.3
392

"They"?

395

Repetitive, I know, but I'd prefer "audio device" here (and below) for clarity - there's also the mixer device, right?

christos updated this revision to Diff 141805.Aug 4 2024, 1:46 PM
christos marked 2 inline comments as done.

Address comments.

Harbormaster completed remote builds in B58937: Diff 141805.Aug 4 2024, 1:46 PM
christos added inline comments.Aug 4 2024, 1:47 PM
lib/libmixer/mixer.3
392

Typo.

395

No objection, although in this specific sentence it's clear that we refer to the audio device. Will update the diff now.

dev_submerge.ch accepted this revision.Aug 4 2024, 2:55 PM

Yeah, it would be obvious from the context - but not everybody reads context ;-)

This revision is now accepted and ready to land.Aug 4 2024, 2:55 PM
Closed by commit rG6e744de1a3dc: mixer.3: Fix mixer_get_mode() description (authored by christos). · Explain WhyAug 5 2024, 11:14 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG6e744de1a3dc: mixer.3: Fix mixer_get_mode() description.
christos added a commit: rGdb238c7c52b3: mixer.3: Fix mixer_get_mode() description.Aug 8 2024, 1:49 PM

Revision Contents
Changeset List

PathSize
lib/
libmixer/
23 lines

Diff 141805

View Options

lib/libmixer/mixer.3

Loading...