mixer.3: Fix mixer_get_mode() description
ClosedPublic
Actions

Authored by christos on Aug 4 2024, 1:28 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rGdb238c7c52b3: mixer.3: Fix mixer_get_mode() description
rG6e744de1a3dc: mixer.3: Fix mixer_get_mode() description

Summary

Improve wording and also fix the constants' names.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Aug 4 2024, 1:28 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 4 2024, 1:28 PM

christos requested review of this revision.Aug 4 2024, 1:28 PM

Harbormaster completed remote builds in B58936: Diff 141803.Aug 4 2024, 1:28 PM

dev_submerge.ch added inline comments.Aug 4 2024, 1:39 PM

lib/libmixer/mixer.3
392	"They"?
395	Repetitive, I know, but I'd prefer "audio device" here (and below) for clarity - there's also the mixer device, right?

Address comments.

Harbormaster completed remote builds in B58937: Diff 141805.Aug 4 2024, 1:46 PM

christos added inline comments.Aug 4 2024, 1:47 PM

lib/libmixer/mixer.3
392	Typo.
395	No objection, although in this specific sentence it's clear that we refer to the audio device. Will update the diff now.

Yeah, it would be obvious from the context - but not everybody reads context ;-)

This revision is now accepted and ready to land.Aug 4 2024, 2:55 PM

Closed by commit rG6e744de1a3dc: mixer.3: Fix mixer_get_mode() description (authored by christos). · Explain WhyAug 5 2024, 11:14 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG6e744de1a3dc: mixer.3: Fix mixer_get_mode() description.

christos added a commit: rGdb238c7c52b3: mixer.3: Fix mixer_get_mode() description.Aug 8 2024, 1:49 PM

Revision Contents
Changeset List

Path

Size

lib/

libmixer/

mixer.3

23 lines

Diff 141825

View Options

mixer.3: Fix mixer_get_mode() descriptionClosedPublicActions