Page MenuHomeFreeBSD

loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option
ClosedPublic

Authored by imp on Aug 2 2024, 5:55 PM.
Tags
None
Referenced Files
F101917657: D46212.id.diff
Tue, Nov 5, 2:28 PM
Unknown Object (File)
Fri, Nov 1, 5:11 AM
Unknown Object (File)
Sat, Oct 19, 9:59 AM
Unknown Object (File)
Sat, Oct 19, 9:58 AM
Unknown Object (File)
Sat, Oct 19, 9:58 AM
Unknown Object (File)
Sat, Oct 19, 9:57 AM
Unknown Object (File)
Sat, Oct 19, 9:28 AM
Unknown Object (File)
Oct 1 2024, 11:37 AM

Details

Summary

Make it possible to disable pxeboot. This loader will fail to build when
it's too large. When /boot/loader needs to be larger like that, this
options will disable a component whose build will fail. It is an explicit
option rather than implicit when things are too large to force the user to
make the explicit tradeoffs rather than wonder why they have a stale pxeldr
or other odd failure mode.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Aug 2 2024, 5:55 PM

Typo in the commit log message, PDELDR -> PXELDR.

tools/build/options/WITH_LOADER_PXELDR
1 ↗(On Diff #141742)

What's the difference between pxeldr and pxeboot(8)?

8 ↗(On Diff #141742)
21 ↗(On Diff #141742)

Should this be LOADERSIZE?

tools/build/options/WITH_LOADER_PXELDR
21 ↗(On Diff #141742)

Ah, PXELDRSIZE.

imp retitled this revision from loader: Add WITH/WITHOUT_LOADER_PDELDR build option to loader: Add WITH/WITHOUT_LOADER_PXEBOOT build option.Aug 2 2024, 11:33 PM
imp edited the summary of this revision. (Show Details)

update per review, mostly ldr->boot

tools/build/options/WITH_LOADER_PXELDR
1 ↗(On Diff #141742)

pkeldr is the loader that lives inside of pxeboot.

But most people just know about pxeboot, so I'm renaming the new args to match.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 6 2024, 11:30 PM
This revision was automatically updated to reflect the committed changes.