Page MenuHomeFreeBSD

mcast: fix leaked igmp packets on multicast cleanup
ClosedPublic

Authored by franco_opnsense.org on Jul 31 2024, 8:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 5:14 PM
Unknown Object (File)
Mon, Nov 18, 12:56 AM
Unknown Object (File)
Mon, Nov 18, 12:30 AM
Unknown Object (File)
Fri, Nov 8, 4:18 AM
Unknown Object (File)
Fri, Nov 8, 2:29 AM
Unknown Object (File)
Thu, Oct 24, 3:10 PM
Unknown Object (File)
Thu, Oct 24, 3:10 PM
Unknown Object (File)
Thu, Oct 24, 2:51 PM

Details

Summary

The commits below have not been added to stable/14. They have been known to fix IGMP leave
messages which are currently broken on both 14.0 and 14.1.

Revert "mcast: fix memory leak in imf_purge()"

This reverts commit fa03d37432caf17d56a931a9e6f5d9b06f102c5b.

This commit caused us to not send IGMP leave messages if the inpcb went
away. In other words: we freed pending packets whenever the socket
closed rather than when the interface (or address) goes away.

mcast: fix leaked igmp packets on multicast cleanup

When we release a multicast address (e.g. on interface shutdown) we may
still have packets queued in inm_scq. We have to free those, or we'll
leak memory.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58893
Build 55780: arc lint + arc unit

Event Timeline

franco_opnsense.org retitled this revision from Revert "mcast: fix memory leak in imf_purge()" to mcast: fix leaked igmp packets on multicast cleanup.Jul 31 2024, 8:52 AM
franco_opnsense.org edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 13 2024, 5:18 PM

This has already been merged.