Page MenuHomeFreeBSD

linuxkpi: Small tweaks to _ONCE macros
AbandonedPublic

Authored by imp on Jul 25 2024, 11:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 9:02 PM
Unknown Object (File)
Sun, Mar 30, 3:33 AM
Unknown Object (File)
Sun, Mar 30, 12:26 AM
Unknown Object (File)
Sat, Mar 29, 12:31 PM
Unknown Object (File)
Fri, Mar 28, 12:28 PM
Unknown Object (File)
Mon, Mar 17, 7:30 AM
Unknown Object (File)
Sun, Mar 16, 3:51 AM
Unknown Object (File)
Feb 16 2025, 7:06 PM
Subscribers

Details

Reviewers
None
Group Reviewers
linuxkpi
Summary

Provide ACCESS_ONCE and use it where it was inlined in READ_ONCE and
WRITE_ONCE. This will allow us to use the Linux KPI version of
compiler.h rather than the ancient copy of it for OpenZFS.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58838
Build 55725: arc lint + arc unit

Event Timeline

imp requested review of this revision.Jul 25 2024, 11:57 PM
bz added a subscriber: bz.

Please see 046d8d89ed1956944b12ec4f0580c30bc202bbfb . Seems you are reverting that.

It does undo the ACCESS_ONCE part of it, but doesn't undo the proper uintptr_t casting part. Oh, but I see the const cast is there for READ...
I can omit that bit too. OpenZFS really just reads READ_ONCE and WRITE_ONCE anyway. It
suffers from defining this stuff in too many different places :(.

So once I do all that, I can just drop this commit....