Page MenuHomeFreeBSD

cdefs: Add __deprecated
ClosedPublic

Authored by imp on Jul 25 2024, 5:31 PM.
Tags
None
Referenced Files
F102658521: D46137.diff
Fri, Nov 15, 11:24 AM
Unknown Object (File)
Tue, Nov 12, 1:09 AM
Unknown Object (File)
Sat, Nov 2, 6:23 PM
Unknown Object (File)
Thu, Oct 17, 1:20 AM
Unknown Object (File)
Oct 15 2024, 9:18 PM
Unknown Object (File)
Oct 3 2024, 8:28 PM
Unknown Object (File)
Sep 18 2024, 12:05 AM
Unknown Object (File)
Sep 10 2024, 8:58 AM

Details

Summary

Add __deprecated decorator. This is for a deprecated interface. We use
it today in our documentation, but don't actually provide it or use it.

Also, OpenZFS has a poorly-updated copy of compiler.h that we'll need
to fix upstream before this can land. Ideally, they'd be identical (and
OpenZFS would use the linuxkpi in FreeBSD version).

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jul 25 2024, 5:31 PM

copystr (see copy(9)) might be a good candidate for this that might justify adding it?

The tense in the commit message confused me: when the commit lands we will provide __deprecated so it won't be correct to say we don't provide it.

This revision is now accepted and ready to land.Jul 25 2024, 5:36 PM

The tense in the commit message confused me: when the commit lands we will provide __deprecated so it won't be correct to say we don't provide it.

Perhaps 's/don't actually/don't currently/' or 's/don't actually provide/haven't been providing or using it/'?

Yea, I hadn't planned on including the second paragraph...

Also, just looked at Linux. It defines this as just a decorator. It used to provide warnings, but doesn't anymore.
So this could whine more than Linux does when we compile linuxkpi items that provide deprecated interfaces.

Also also: it can take an arg that's a message, so maybe we want to include that.

This revision was automatically updated to reflect the committed changes.