ls: Make -, apply to -s as well as -l.
ClosedPublic
Actions

Authored by des on Jul 22 2024, 8:14 PM.

Details

Reviewers

Commits

rG600504767528: ls: Make -, apply to -s as well as -l.
rGe6d9c11666f7: ls: Make -, apply to -s as well as -l.
rG647d4a8cafd2: ls: Make -, apply to -s as well as -l.

Summary

While here, remove a bogus comment about a gcc bug. The bug was in ls,
which used an incorrect format string, and in libc, which accepted it.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58765
Build 55653: arc lint + arc unit

Event Timeline

des created this revision.Jul 22 2024, 8:14 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 22 2024, 8:14 PM

des requested review of this revision.Jul 22 2024, 8:14 PM

Harbormaster completed remote builds in B58765: Diff 141237.Jul 22 2024, 8:14 PM

Note that, independently of this change, I'm not convinced ls -s reports the right information. It seems to assume that the block size is fixed and universal, while on ZFS it can vary from one file to another. I believe ls should switch to keeping blocksize in bytes and printing howmany(st_blocks * st_blksize, blocksize) instead of keeping blocksize in units of 512 bytes and printing howmany(st_blocks, blocksize).

Ignore this, st_blocks is always in units of 512 bytes, not in units of st_blksize.

brooks accepted this revision.Jul 24 2024, 7:20 PM

This revision is now accepted and ready to land.Jul 24 2024, 7:20 PM

Closed by commit rG647d4a8cafd2: ls: Make -, apply to -s as well as -l. (authored by des). · Explain WhyJul 24 2024, 8:07 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG647d4a8cafd2: ls: Make -, apply to -s as well as -l..

des added a commit: rGe6d9c11666f7: ls: Make -, apply to -s as well as -l..Aug 1 2024, 4:17 PM

des added a commit: rG600504767528: ls: Make -, apply to -s as well as -l..Aug 1 2024, 4:47 PM