usr.sbin/uhsoctl: correct SIOCDIFADDR calls to use ifreq

[def]

Summary

The SIOCDIFADDR ioctl takes an ifreq structure object, not an ifaliasreq
structure object, as its argument.

Obtained from: CheriBSD

[def]

@brooks @oshogbo Do you have any suggestions who should review this? It is not clear to me based on the commit history.

[brooks]

FWIW, this program and the associated driver are pretty old and with 3g being phased out fairly rapidly in much of the world it should probably be removed soon.

The only real mention I found was https://dmesgd.nycbug.org/index.cgi?do=view&id=4517 and that appears to be a 2008/2009 vintage laptop.

[jhb]

usr.sbin/uhsoctl/uhsoctl.c

437

Given that there's no longer a lot of shared code here, I would just remove ifaddr_ad entirely and push the logic down into these two functions directly instead.

444

Ideally we'd remove the mask argument from here as well.

[oshogbo]

usr.sbin/uhsoctl/uhsoctl.c

374

bzero?

381

ditto.

[def]

Remove ifaddr_ad() and move its logic to callers.

[def]

usr.sbin/uhsoctl/uhsoctl.c

374

Isn't bzero() deprecated? Also, uhsoctl already uses memset(..., 0, ...) so I guess it's better to be consistent here.

381

Same as above.

437

I removed ifaddr_ad() and moved its logic to callers.

I updated the commit message to explain that SIOCDIFADDR does not use a netmask.

444

I removed the mask argument.

[jhb]

usr.sbin/uhsoctl/uhsoctl.c

374

Yes, memset() (POSIX) is preferred over bzero() (BSD-only) at this point.

[oshogbo]

Oh, ok.