openssl: Add <sys/random.h> include for getrandom()

[jhb]

Summary

GCC 14 (but not earlier versions) warns about a missing prototype
for getrandom(). Include <sys/random.h> explicitly to bring in the
prototype rather than depending on a nested include. While here,
stop defining sysctl_random() since it is no longer used.

Fixes: 838b6caababb openssl: use getrandom(2) instead of probing for getentropy(2)

[jhb]

crypto/openssl/providers/implementations/rands/seeding/rand_unix.c

31

I'm not sure why this is checking for OPENSSL_SYS_UEFI instead of KERN_ARND. That seems like an upstream bug.

No good explanation here:

https://github.com/openssl/openssl/commit/e2e4b784e65eaafb133a7db3d344446c43112d41

This commit seems a bit odd though and suggests we should instead move this down condition down to follow where FreeBSD goes?

https://github.com/openssl/openssl/commit/1fa90bb3a9089f974e9b07f3e76a964bd2da6976

231

If this is upstreamed as-is then this block can be removed as well.

[jhb]

Move UEFI condition

[kevans]

crypto/openssl/providers/implementations/rands/seeding/rand_unix.c

216

In the change proposed we still use this on FreeBSD versions earlier than 12.x for now: https://github.com/openssl/openssl/pull/24903/files

We should have a follow-up discussion with them about what they want OS support wise, I suspect there's a lot of cruft that can go away from long-since EoL versions.

[imp]

https://github.com/freebsd/freebsd-src/pull/1335 has a less good version of this patch.