Page MenuHomeFreeBSD
Differential D45838

EVDEV: fix incorrect mouse button reporting
ClosedPublic
Actions

Authored by nsonack_outlook.com on Jul 2 2024, 6:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 19, 9:43 PM
Unknown Object (File)
Wed, Sep 18, 7:29 PM
Unknown Object (File)
Wed, Sep 18, 6:02 PM
Unknown Object (File)
Wed, Sep 18, 6:44 AM
Unknown Object (File)
Tue, Sep 17, 6:22 PM
Unknown Object (File)
Tue, Sep 17, 12:59 AM
Unknown Object (File)
Mon, Sep 16, 9:05 PM
Unknown Object (File)
Mon, Sep 16, 11:03 AM
View All 22 Files
Subscribers
imp
desktop

Details

Reviewers
wulf
imp
Commits
rG66292e70e84d: ums(4): fix incorrect mouse button reporting via evdev
rGb21881d8c421: ums(4): fix incorrect mouse button reporting via evdev
rGd6888e211b07: ums(4): fix incorrect mouse button reporting via evdev
Summary

Without this patch I see the following symptoms:

  • Mouse used: CHERRY MW 8C Ergo (VID = 046a, PID = c118)
  • Push any button and start dragging
  • Note that it quickly selects but then releases the button despite it still being pressed causing selections to be aborted

This is particularly annoying in X11 and Wayland which both suffer from the same symptom. It does however not happen with moused.

This patch fixes the order of initialisation of the buttons_reported variable.

Reference: e012a280a584 (EVDEV: ums evdev support improvements: locking and event reporting, 2016-10-22)
Very Likely Fixes: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274830

Test Plan

I have tested this with a few mouses and it seems to work just fine. Maybe some of the people on the Bugzilla bug report can test this too.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
input/
5 lines

Diff 140483

View Options

sys/dev/usb/input/ums.c

Loading...