Page MenuHomeFreeBSD
Differential D45822

if_vxlan(4): Plug a memory leak
ClosedPublic
Actions

Authored by zlei on Jul 1 2024, 12:47 PM.
Tags
None
Referenced Files
F98876066: D45822.diff
Sat, Oct 5, 3:16 AM
F98805988: D45822.id140424.diff
Fri, Oct 4, 8:01 PM
F98695543: D45822.id140424.diff
Fri, Oct 4, 9:40 AM
Unknown Object (File)
Wed, Oct 2, 3:32 AM
Unknown Object (File)
Tue, Oct 1, 11:56 AM
Unknown Object (File)
Sat, Sep 28, 11:48 PM
Unknown Object (File)
Tue, Sep 24, 1:06 PM
Unknown Object (File)
Fri, Sep 20, 4:34 PM
View All 36 Files
Subscribers
ae
glebius
imp
kp
melifaro

Details

Reviewers
np
kp
glebius
Group Reviewers
network
Commits
rG12bd1341d2aa: if_vxlan(4): Plug a memory leak
rGe729e750806d: if_vxlan(4): Plug a memory leak
rG087f5e08ab5f: if_vxlan(4): Plug a memory leak
Summary

On clone creating, either failure from vxlan_set_user_config() or
ifc_copyin() will result in leaking previous allocated counters.

Since counter_u64_alloc(M_WAITOK) never fails, make vxlan_stats_alloc()
void and move the allocation for counters below checking ifd->params to
avoid memory leak.

Fixes: b092fd6c973d if_vxlan(4): add support for hardware assisted checksumming, TSO, and RSS
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Jul 1 2024, 12:47 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptJul 1 2024, 12:47 PM
zlei requested review of this revision.Jul 1 2024, 12:47 PM
kp accepted this revision as: kp.Jul 1 2024, 4:01 PM
kp added a subscriber: kp.
kp added inline comments.
sys/net/if_vxlan.c
2955

counter_u64_free(NULL) is safe (now), so even without the other changes getting rid of the check would be fine.

This revision is now accepted and ready to land.Jul 1 2024, 4:01 PM
glebius accepted this revision as: glebius.Jul 1 2024, 9:55 PM
zlei marked an inline comment as done.Jul 2 2024, 4:53 AM
zlei added inline comments.
sys/net/if_vxlan.c
2955

Indeed.

Closed by commit rG087f5e08ab5f: if_vxlan(4): Plug a memory leak (authored by zlei). · Explain WhyJul 2 2024, 4:59 AM
This revision was automatically updated to reflect the committed changes.
zlei marked an inline comment as done.
zlei added a commit: rG087f5e08ab5f: if_vxlan(4): Plug a memory leak.
zlei added a commit: rGe729e750806d: if_vxlan(4): Plug a memory leak.Jul 10 2024, 10:18 AM
zlei added a commit: rG12bd1341d2aa: if_vxlan(4): Plug a memory leak.Jul 10 2024, 11:45 AM

Revision Contents
Changeset List

PathSize
sys/
net/
36 lines

Diff 140450

View Options

sys/net/if_vxlan.c

Loading...