There may be a nicer way to spell this.
Details
Details
make buildkernel on amd64 and i386, examine warnings
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
why the crazy vm_offset_t instead of uintptr_t??
sys/dev/nvme/nvme_ctrlr.c | ||
---|---|---|
1366–1367 | why not (uintptr_t) here and below? |
Comment Actions
Yeah, I think you're right. I waffled on that, I'm happy to make it uintptr_t, I believe they're always the same size.
My drive-by understanding was that in the is_user block, npc->addr is a user address and in that sense vm_offset_t may technically be more appropriate to represent it than a pointer (and vmapbuf casts the pointer to vm_offset_t)... but I'm not proposing we change the vmapbuf prototype for this, and anyway that doesn't apply to the second case.
I'll fix this up with uintptr_t this evening.