and dummy num_possible_nodes() implementation. We do not support NUMA
in LinuxKPI yet.
Sponsored by: Serenity Cyber Security, LLC
MFC after: 1 week
Details
Details
- Reviewers
bz manu dumbbell emaste - Group Reviewers
linuxkpi - Commits
- rGf1f6228a6658: LinuxKPI: Add linux/nodemask.h
rG889f74af66b8: LinuxKPI: Add linux/nodemask.h
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/compat/linuxkpi/common/include/linux/nodemask.h | ||
|---|---|---|
| 36 | Can you leave a pr_debug() call here (instead of the comment); that way it can become visible. | |
| sys/compat/linuxkpi/common/include/linux/nodemask.h | ||
|---|---|---|
| 32 | Also not entirely true; see compat/common/src/linux_domain.c There is one instance where we do seem to return the domain. | |
| sys/compat/linuxkpi/common/include/linux/nodemask.h | ||
|---|---|---|
| 36 | Depending on when this function is used in DRM this could be annoying as hell. | |
| sys/compat/linuxkpi/common/include/linux/nodemask.h | ||
|---|---|---|
| 36 |
pr_debug is behind a sysctl and off by default and off unless we have a kernel compiled with options DEBUG (to my memory). | |
| sys/compat/linuxkpi/common/include/linux/nodemask.h | ||
|---|---|---|
| 36 | Indeed, I've missed the sysctl, I'm good for using it then. | |
| sys/compat/linuxkpi/common/include/linux/nodemask.h | ||
|---|---|---|
| 36 | I left a comment on the GitHub that we should have a consistent way to tag TODO items in the Linuxulator; I was thinking of something like a LKPITODO comment but it seems that pr_debug("%s: TODO\n", __func__); is indeed the typical incantation. | |