Page MenuHomeFreeBSD
Differential D45570

ifconfig: Fix default netmask calculation
ClosedPublic
Actions

Authored by grembo on Jun 12 2024, 4:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 19 2025, 3:57 PM
Unknown Object (File)
Feb 26 2025, 9:25 PM
Unknown Object (File)
Feb 24 2025, 10:35 AM
Unknown Object (File)
Feb 23 2025, 1:18 AM
Unknown Object (File)
Jan 19 2025, 8:19 AM
Unknown Object (File)
Jan 19 2025, 4:50 AM
Unknown Object (File)
Jan 10 2025, 4:47 PM
Unknown Object (File)
Nov 21 2024, 6:36 AM
View All 42 Files
Subscribers
imp

Details

Reviewers
bz
phk
emaste
kp
Commits
rG01792dd7f27b: ifconfig: Fix default netmask calculation
rGb9115dba07e8: ifconfig: Fix default netmask calculation
rG048ad7a9ef9f: ifconfig: Fix default netmask calculation
rG8a9f0fa42b1c: ifconfig: Fix default netmask calculation
Summary

In case an interface address without mask is set
(deprecated), use the correct bitmask (32 - nshift).

Test Plan

manual

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58157
Build 55045: arc lint + arc unit

Event Timeline

grembo created this revision.Jun 12 2024, 4:14 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 12 2024, 4:14 PM
grembo requested review of this revision.Jun 12 2024, 4:14 PM
Harbormaster completed remote builds in B58157: Diff 139759.Jun 12 2024, 4:14 PM
grembo added reviewers: bz, phk.Jun 12 2024, 4:16 PM
grembo added a comment.Jun 12 2024, 5:13 PM

There might be more correct ways to fix this, logically it should be sound.

Should be MFCed to 14.0 and 14.1 and maybe also deserves an EN.

emaste accepted this revision.Jun 12 2024, 5:47 PM
This revision is now accepted and ready to land.Jun 12 2024, 5:47 PM
kp accepted this revision.Jun 12 2024, 5:57 PM
Closed by commit rG8a9f0fa42b1c: ifconfig: Fix default netmask calculation (authored by grembo). · Explain WhyJun 12 2024, 6:12 PM
This revision was automatically updated to reflect the committed changes.
grembo added a commit: rG8a9f0fa42b1c: ifconfig: Fix default netmask calculation.
emaste mentioned this in D45585: ifconfig: turn interface address without mask into an error.Jun 13 2024, 5:47 PM
grembo added a commit: rG048ad7a9ef9f: ifconfig: Fix default netmask calculation.Jun 15 2024, 3:27 PM
markj added a commit: rGb9115dba07e8: ifconfig: Fix default netmask calculation.Aug 7 2024, 1:45 PM
markj added a commit: rG01792dd7f27b: ifconfig: Fix default netmask calculation.

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
8 lines

Diff 139759

View Options

sbin/ifconfig/af_inet.c

Loading...