prepare-commit-msg: add 50 column marker
ClosedPublic
Actions

Authored by emaste on Jun 9 2024, 5:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 1, 2:19 AM

	Unknown Object (File)
	Fri, Nov 1, 2:19 AM

	Unknown Object (File)
	Fri, Nov 1, 2:19 AM

	Unknown Object (File)
	Fri, Nov 1, 1:57 AM

	Unknown Object (File)
	Sat, Oct 19, 11:20 AM

	Unknown Object (File)
	Fri, Oct 18, 9:09 AM

	Unknown Object (File)
	Oct 5 2024, 11:42 PM

	Unknown Object (File)
	Oct 2 2024, 4:02 AM

View All Files

Subscribers

lwhsu

Details

Reviewers

imp
lwhsu

Commits

rG87e5b17c149e: prepare-commit-msg: add 50 column marker

Summary

A common convention suggests a 50 column commit subject line (the first
line of the commit message). Add a 50 column marker to the commit
message template

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Jun 9 2024, 5:27 PM

emaste created this revision.

How about adding a second comment line says that the 50 is for subject and 72 is for body?

This revision is now accepted and ready to land.Jun 9 2024, 10:13 PM

How about adding a second comment line says that the 50 is for subject and 72 is for body?

I started writing some extra text but then it seems we should also comment on the blank 2nd line and it got to be a tutorial rather than a quick reference. Perhaps we could add a link to the section in the committer's guide. For now I'll commit this bit.

Closed by commit rG87e5b17c149e: prepare-commit-msg: add 50 column marker (authored by emaste). · Explain WhyJun 10 2024, 2:49 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG87e5b17c149e: prepare-commit-msg: add 50 column marker.