Page MenuHomeFreeBSD
Differential D45523

simd(7): add missing aarch64 SIMD functions
ClosedPublic
Actions

Authored by getz on Jun 7 2024, 12:00 PM.
Tags
None
Referenced Files
F96322432: D45523.diff
Tue, Sep 24, 2:31 PM
Unknown Object (File)
Sat, Sep 7, 7:32 AM
Unknown Object (File)
Sat, Sep 7, 12:21 AM
Unknown Object (File)
Aug 13 2024, 11:34 AM
Unknown Object (File)
Aug 10 2024, 5:03 PM
Unknown Object (File)
Aug 10 2024, 8:55 AM
Unknown Object (File)
Aug 8 2024, 10:06 AM
Unknown Object (File)
Aug 6 2024, 5:53 PM
View All 21 Files
Subscribers
imp

Details

Reviewers
fuz
emaste
Commits
rGa40287d6312e: simd(7): add missing aarch64 SIMD functions
rG6c5ee6e55a35: simd(7): add missing aarch64 SIMD functions
Summary

Some of the string functions in contrib/arm-optimized routines are SIMD enhanced
which is not reflect on the simd(7) manpage. This commit addresses that and
introduces a new label A for functions enhanced with the Arm Neon extension (ASIMD).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58096
Build 54984: arc lint + arc unit

Event Timeline

getz created this revision.Jun 7 2024, 12:00 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 7 2024, 12:00 PM
getz requested review of this revision.Jun 7 2024, 12:00 PM
Harbormaster completed remote builds in B58095: Diff 139617.Jun 7 2024, 12:00 PM
getz added reviewers: fuz, emaste.Jun 7 2024, 12:00 PM
fuz added inline comments.Jun 7 2024, 12:34 PM
share/man/man7/simd.7
104

ARM's current branding for this instruction set extension is ASIMD. Alternatively, NEON in all-caps. Either is fine with me, but if you change to ASIMD, please also change the key letter to A for ASIMD.

getz updated this revision to Diff 139618.Jun 7 2024, 1:06 PM
  • simd(7): ASIMD instead of Neon
Harbormaster completed remote builds in B58096: Diff 139618.Jun 7 2024, 1:06 PM
getz added inline comments.Jun 7 2024, 1:08 PM
share/man/man7/simd.7
104

I'll go with A for ASIMD, I found use of of both Neon and NEON in Arm marketing material.

getz edited the summary of this revision. (Show Details)Jun 7 2024, 1:57 PM
emaste added inline comments.Jun 7 2024, 2:03 PM
share/man/man7/simd.7
104

Are they just synonyms? We might want to say ASIMD (also known as NEON) or something similar.

getz added inline comments.Jun 7 2024, 3:31 PM
share/man/man7/simd.7
104

Agreed, I'll change it. NEON is what its more commonly referred to afaik.

getz updated this revision to Diff 139628.Jun 7 2024, 3:37 PM
  • simd(7): also mention (NEON)
Harbormaster completed remote builds in B58104: Diff 139628.Jun 7 2024, 3:37 PM
fuz accepted this revision.Jun 7 2024, 4:16 PM

LGTM. Still needs a src committer to approve for commit though.

This revision is now accepted and ready to land.Jun 7 2024, 4:16 PM
emaste accepted this revision.Jun 7 2024, 4:22 PM
Closed by commit rG6c5ee6e55a35: simd(7): add missing aarch64 SIMD functions (authored by getz, committed by fuz). · Explain WhyJun 9 2024, 4:11 PM
This revision was automatically updated to reflect the committed changes.
fuz added a commit: rG6c5ee6e55a35: simd(7): add missing aarch64 SIMD functions.
fuz added a commit: rGa40287d6312e: simd(7): add missing aarch64 SIMD functions.Jun 9 2024, 4:13 PM

Revision Contents
Changeset List

PathSize
share/
man/
man7/
31 lines

Diff 139618

View Options

share/man/man7/simd.7

Loading...