sound: Include sound(4) channel information in sndstat nvlist
ClosedPublic
Actions

Authored by christos on Jun 5 2024, 6:36 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rGe6ecffccdec6: sound: Include sound(4) channel information in sndstat nvlist
rGbbca3a75bb41: sound: Include sound(4) channel information in sndstat nvlist

Summary

Extend SNDST_DSPS_PROVIDER_INFO for sound(4) to include information
about each channel in a given device, similar to how cat'ing
/dev/sndstat with hw.snd.verbose=2 works.

While here, document all provider_info fields.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Test Plan

Quick test program: P638
Test results: P639

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Jun 5 2024, 6:36 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 5 2024, 6:36 PM

christos requested review of this revision.Jun 5 2024, 6:36 PM

Harbormaster completed remote builds in B58073: Diff 139523.Jun 5 2024, 6:36 PM

christos edited the test plan for this revision. (Show Details)Jun 5 2024, 6:40 PM

markj added inline comments.Jun 5 2024, 9:40 PM

share/man/man4/sndstat.4
166
184
194
196
sys/dev/sound/pcm/sndstat.c
465	We leak `sb` in this path. (But why not keep the sbuf on the stack?)

Address Mark's comments.

Harbormaster completed remote builds in B58084: Diff 139573.Jun 6 2024, 3:26 PM

Seems ok to me.

sys/dev/sound/pcm/sndstat.c
460	You don't need to check the return value here unless `SBUF_NOWAIT` was passed.

This revision is now accepted and ready to land.Jun 6 2024, 3:35 PM

christos marked an inline comment as done.Jun 7 2024, 1:23 PM

I couldn't build the test program, missing some symbols like FreeBSD_nvlist_exists? How is an application supposed to consume this?

Apart from that it looks good to me.

In D45501#1038856, @dev_submerge.ch wrote:

I couldn't build the test program, missing some symbols like FreeBSD_nvlist_exists? How is an application supposed to consume this?

Apart from that it looks good to me.

Applications can consume this the same way they'd consume the rest of the nvlist. The OSS library I am creating is making use of some of these new fields (as well as some old ones) to fetch information that is not provided by the AUDIOINFO and ENGINEINFO ioctls.

Closed by commit rGbbca3a75bb41: sound: Include sound(4) channel information in sndstat nvlist (authored by christos). · Explain WhyJun 9 2024, 3:30 PM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGbbca3a75bb41: sound: Include sound(4) channel information in sndstat nvlist.

christos added a commit: rGe6ecffccdec6: sound: Include sound(4) channel information in sndstat nvlist.Jun 14 2024, 4:58 PM