Details

Reviewers

mhorne
jrtc27

Commits

rG62cb671705eb: riscv: include ahci device to GENERIC.

Summary

Iinclude AHCI for PCI-e block device emulation.

(needed for Guest VM)

Test Plan

tested on bhyve

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

br created this revision.Jun 5 2024, 12:39 PM

Herald added a subscriber: riscv. · View Herald TranscriptJun 5 2024, 12:39 PM

place device directives before include

remove duplicates

Please use conventional RISC-V IP. For the UART the platform standards want an 8250, and that’s what QEMU’s virt machine provides. For the RTC the goldfish RTC is simple to emulate and what its virt machine uses. If an OS boots on QEMU it should boot on bhyve.

This revision now requires changes to proceed.Jun 5 2024, 3:44 PM

Include AHCI only

In D45497#1037945, @jrtc27 wrote:

Please use conventional RISC-V IP. For the UART the platform standards want an 8250, and that’s what QEMU’s virt machine provides. For the RTC the goldfish RTC is simple to emulate and what its virt machine uses. If an OS boots on QEMU it should boot on bhyve.

Ok I managed to switch to ns16550 uart, but for RTC it is not something I want to focus on currently, so we can do that later.
So lets include just ahci for now

mhorne accepted this revision.Jun 7 2024, 4:13 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2024, 12:42 PM

Closed by commit rG62cb671705eb: riscv: include ahci device to GENERIC. (authored by br). · Explain Why

This revision was automatically updated to reflect the committed changes.

br added a commit: rG62cb671705eb: riscv: include ahci device to GENERIC..

Herald added a subscriber: imp. · View Herald TranscriptJun 12 2024, 12:42 PM