Page MenuHomeFreeBSD

mbuf: provide m_freemp()
ClosedPublic

Authored by glebius on Jun 3 2024, 8:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 12, 5:24 PM
Unknown Object (File)
Sun, Sep 8, 6:01 PM
Unknown Object (File)
Thu, Sep 5, 1:11 AM
Unknown Object (File)
Tue, Sep 3, 8:06 AM
Unknown Object (File)
Sun, Sep 1, 1:02 PM
Unknown Object (File)
Aug 14 2024, 1:15 AM
Unknown Object (File)
Aug 7 2024, 6:01 PM
Unknown Object (File)
Aug 4 2024, 1:58 PM
Subscribers

Details

Summary

This function follows both m_nextpkt and m_next linkage freeing all mbufs.
Note that existing m_freem() follows only m_next.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 3 2024, 8:15 PM
sys/kern/kern_mbuf.c
1595

m_freem() lets you pass NULL, but this function does not. Is that deliberate?

sys/kern/kern_mbuf.c
1595

Yes. I believe a good code should not call free(NULL). Of course we are obliged to support free(NULL) in userland and in kernel as well as some other freeing functions, e.g. m_freem(). I will provide a comment on top of m_freemp() that it doesn't support NULL argument.

This revision was automatically updated to reflect the committed changes.