comm: handle input arguments being NULL
Needs ReviewPublic
Actions

Authored by ccecchi_apple.com on Jun 1 2024, 3:55 PM.

Tags

None

Referenced Files

	F107935181: D45438.diff
	Sun, Jan 19, 4:48 PM

	Unknown Object (File)
	Sun, Jan 5, 2:39 PM

	Unknown Object (File)
	Dec 13 2024, 12:39 AM

	Unknown Object (File)
	Nov 2 2024, 3:35 AM

	Unknown Object (File)
	Oct 26 2024, 5:59 PM

	Unknown Object (File)
	Oct 24 2024, 7:28 PM

	Unknown Object (File)
	Oct 5 2024, 7:28 AM

	Unknown Object (File)
	Oct 5 2024, 5:29 AM

View All 20 Files

Subscribers

imp

Details

Reviewers

ache
allanjude

Summary

comm would currently crash when input arguments are NULL.
This commit adds a simple NULL check to prevent that situation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57988
Build 54876: arc lint + arc unit

Event Timeline

ccecchi_apple.com created this revision.Jun 1 2024, 3:55 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 1 2024, 3:55 PM

ccecchi_apple.com requested review of this revision.Jun 1 2024, 3:55 PM

Harbormaster completed remote builds in B57988: Diff 139303.Jun 1 2024, 3:55 PM

ccecchi_apple.com added a child revision: D45439: comm: flush stdout for error checking prior to exiting.Jun 1 2024, 3:56 PM

ccecchi_apple.com added reviewers: ache, allanjude.Jun 1 2024, 4:00 PM

imp added inline comments.Jun 1 2024, 5:26 PM

usr.bin/comm/comm.c
92	How can these be NULL if argc == 2?

Revision Contents
Changeset List

Path

Size

usr.bin/

comm/

comm.c

2 lines

Diff 139303

View Options

comm: handle input arguments being NULLNeeds ReviewPublicActions