Page MenuHomeFreeBSD

cxgbe: handle vlan PF restrictions
ClosedPublic

Authored by kp on May 31 2024, 7:53 PM.
Tags
None
Referenced Files
F107928206: D45428.diff
Sun, Jan 19, 2:05 PM
F107870344: D45428.id139275.diff
Sat, Jan 18, 9:24 PM
Unknown Object (File)
Thu, Jan 16, 8:25 PM
Unknown Object (File)
Dec 6 2024, 5:50 PM
Unknown Object (File)
Nov 25 2024, 2:00 AM
Unknown Object (File)
Nov 24 2024, 12:18 PM
Unknown Object (File)
Nov 24 2024, 3:16 AM
Unknown Object (File)
Nov 23 2024, 9:33 AM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57981
Build 54869: arc lint + arc unit

Event Timeline

kp requested review of this revision.May 31 2024, 7:53 PM

This PF change looks correct but there needs to be matching change in the VF driver that reads the VLAN settings and acts on it.

This revision is now accepted and ready to land.Jun 12 2024, 8:07 PM
sys/dev/cxgbe/t4_iov.c
380

A valid PF needs to be provided here. I had to make changes to this revision when I tried it together with D45402 to get the PF side of things to work. Then I had to make some changes to the cxgbe VF driver to read the VLAN configuration during attach. I have a patch for that as well.

sys/dev/cxgbe/t4_iov.c
380

I'm not quite following on what needs to be changed here.
Should we be passing adap->pf instead of vfnum + 1 or something else?

{F86253090} I uploaded an attachment with all the changes I had to make to get this working. Please incorporate it into this revision.

sys/dev/cxgbe/t4_iov.c
380

See attached patch. The pf number of the iov VF, not the adapter vf needs to be passed onto the hw.c routine, which also needs to set the proper pmask using the pf passed in.

This revision was automatically updated to reflect the committed changes.