Page MenuHomeFreeBSD

linux: Translate Linux NVME ioctls to the lower layers.
ClosedPublic

Authored by imp on May 30 2024, 6:30 PM.
Tags
None
Referenced Files
F110036228: D45416.diff
Wed, Feb 12, 7:39 PM
Unknown Object (File)
Thu, Jan 23, 4:59 PM
Unknown Object (File)
Tue, Jan 21, 6:00 AM
Unknown Object (File)
Jan 13 2025, 4:29 AM
Unknown Object (File)
Nov 25 2024, 3:15 AM
Unknown Object (File)
Nov 24 2024, 8:05 PM
Unknown Object (File)
Nov 24 2024, 10:01 AM
Unknown Object (File)
Nov 23 2024, 11:06 PM
Subscribers
None

Details

Summary

The lower layers implement a ABI compatible Linux ioctl for a few of the
Linux IOCTLs. Translate them and pass them down. Since they are ABI
compatible, just use the nvme ioctl name.

Co-Authored-by: Warner Losh <imp@bsdimp.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.May 30 2024, 6:30 PM
imp created this revision.

Testing with an unmodified Linux nvme-cli fails without the noted change masking cmd. Fix that, and this LGTM. Thanks for all the integration!

sys/compat/linux/linux_ioctl.c
3545

nit: 'Nvme' should be 'NVMe'

3549

cmd needs to be masked. I.e.,

+       switch (args->cmd & UINT16_MAX)
This revision is now accepted and ready to land.Jun 9 2024, 5:34 PM

update, per chuck's feedback. Used &0xffff instead of his suggestion
to match the rest of the file.

This revision now requires review to proceed.Jun 14 2024, 9:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 14 2024, 10:40 PM
This revision was automatically updated to reflect the committed changes.