cross-build: Move fcntl.h workaround to Linux specific file
ClosedPublic
Actions

Authored by imp on May 26 2024, 9:21 PM.

Details

Reviewers

jrtc27
val_packett.cool

Commits

rG4a0b7955fd72: cross-build: Move fcntl.h workaround to Linux specific file

Summary

Move the cdefs.h inclusion to the Linux specific file. Either place will
work, but it makes more sense to do it in the Linux specific file since
it's a Linux specific workaround.

Fixes: 4300e053618f
Suggested by: arichards, jrtc27
Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57925
Build 54813: arc lint + arc unit

Event Timeline

imp requested review of this revision.May 26 2024, 9:21 PM

imp created this revision.

Harbormaster completed remote builds in B57925: Diff 139126.May 26 2024, 9:21 PM

imp added a child revision: D45374: cross-build: progname.c is used only on linux, so no ifdefs needed.May 26 2024, 9:21 PM

imp mentioned this in D45351: build: Include sys/cdefs.h in our fcntl.h shim.May 26 2024, 9:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 25 2024, 2:48 AM

Closed by commit rG4a0b7955fd72: cross-build: Move fcntl.h workaround to Linux specific file (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG4a0b7955fd72: cross-build: Move fcntl.h workaround to Linux specific file.

Revision Contents
Changeset List

Path

Size

tools/

build/

cross-build/

include/

linux/

fcntl.h

7 lines

fcntl.h

7 lines

Diff 139126

View Options

tools/build/cross-build/include/linux/fcntl.h