Page MenuHomeFreeBSD
Differential D45368

uma: Fix improper uses of UMA_MD_SMALL_ALLOC
ClosedPublic
Actions

Authored by bnovkov on May 26 2024, 8:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 7:42 AM
Unknown Object (File)
Thu, Nov 7, 4:35 PM
Unknown Object (File)
Oct 18 2024, 11:12 AM
Unknown Object (File)
Oct 17 2024, 10:22 AM
Unknown Object (File)
Oct 16 2024, 12:54 PM
Unknown Object (File)
Oct 15 2024, 3:35 AM
Unknown Object (File)
Oct 13 2024, 8:07 PM
Unknown Object (File)
Oct 13 2024, 7:24 AM
View All 44 Files
Subscribers
imp

Details

Reviewers
markj
tuexen
rlibby
Commits
rGd25ed6504383: uma: Fix improper uses of UMA_MD_SMALL_ALLOC
Summary

UMA_MD_SMALL_ALLOC was recently replaced by UMA_USE_DMAP, but da76d349b6b1 missed some improper uses of the old symbol.
This change makes sure that UMA_USE_DMAP is used properly in code that selects uma_small_alloc.

Test Plan

Tested on an amd64 VM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bnovkov created this revision.May 26 2024, 8:08 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 26 2024, 8:08 AM
bnovkov requested review of this revision.May 26 2024, 8:08 AM
tuexen accepted this revision.May 26 2024, 8:29 AM

Tested on an arm64 VM.

This revision is now accepted and ready to land.May 26 2024, 8:29 AM
Closed by commit rGd25ed6504383: uma: Fix improper uses of UMA_MD_SMALL_ALLOC (authored by bnovkov). · Explain WhyMay 26 2024, 2:28 PM
This revision was automatically updated to reflect the committed changes.
bnovkov added a commit: rGd25ed6504383: uma: Fix improper uses of UMA_MD_SMALL_ALLOC.
rlibby added a comment.May 26 2024, 5:13 PM

What about arc_available_memory() in sys/contrib/openzfs/module/os/freebsd/zfs/arc_os.c? Isn't that still broken?

bnovkov added a comment.May 26 2024, 10:03 PM
In D45368#1034980, @rlibby wrote:

What about arc_available_memory() in sys/contrib/openzfs/module/os/freebsd/zfs/arc_os.c? Isn't that still broken?

It was, thank you for pointing this out, my disk-grepping tools ignored this directory completely so this wasn't included in the original patch.

PR16230 fixes this.

markj added a comment.May 26 2024, 11:54 PM
In D45368#1035077, @bnovkov wrote:
In D45368#1034980, @rlibby wrote:

What about arc_available_memory() in sys/contrib/openzfs/module/os/freebsd/zfs/arc_os.c? Isn't that still broken?

It was, thank you for pointing this out, my disk-grepping tools ignored this directory completely so this wasn't included in the original patch.

PR16230 fixes this.

I suggest fixing this in FreeBSD as well in the interim, as the bug will cause ZFS to unnecessarily shrink the ARC.

Revision Contents
Changeset List

PathSize
sys/
vm/
6 lines

Diff 139110

View Options

sys/vm/uma_core.c

Loading...