Page MenuHomeFreeBSD

cross: Move Solaris API64 defines to common
ClosedPublic

Authored by imp on May 23 2024, 9:52 PM.
Tags
None
Referenced Files
F103061451: D45329.diff
Wed, Nov 20, 10:32 AM
Unknown Object (File)
Sep 27 2024, 7:15 PM
Unknown Object (File)
Sep 17 2024, 4:21 AM
Unknown Object (File)
Sep 8 2024, 11:46 AM
Unknown Object (File)
Sep 8 2024, 4:22 AM
Unknown Object (File)
Sep 3 2024, 1:02 AM
Unknown Object (File)
Aug 9 2024, 6:25 AM
Unknown Object (File)
Aug 8 2024, 7:35 PM
Subscribers
None

Details

Summary

off64_t is needed for both Linux and MacOS, so move them to the common
area.

Pull Request: https://github.com/freebsd/freebsd-src/pull/1066

Test Plan

I'd like to slice PR-1066 up a bit differently so we can get bits in that we agree on while working on others. The current commits aren't well suited for that, so I'm doing this Phab review to get things started. (also, I can push to my github and do pull requests to run testing too). I'm open to other ways too, but I thought I'd start here to get it rolling because as it is PR-1066 is just too big and disconnected to review effectively.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57885
Build 54773: arc lint + arc unit

Event Timeline

imp requested review of this revision.May 23 2024, 9:52 PM
imp created this revision.
imp edited the test plan for this revision. (Show Details)
imp added a reviewer: val_packett.cool.
This revision is now accepted and ready to land.May 23 2024, 11:00 PM

My mac still builds with this. My ubuntu 22.4 is still chugging away at it

Though please mention that it's needed for musl in the commit message, otherwise it's not clear why we've been fine without this diff for years

59aa64914aeb1b2cccc0d4fc39ead2ee159a1e5b landed this. Forgot to update the commit message so this would autoclose.