Do like bus_space(9) does. This fixes the build on platforms where
bus_addr_t and bus_size_t are different (like i386 PAE).
Fixes: c2e9c5bbf022 tpm: Refactor TIS and add a SPI attachment
Differential D45287
tpm_if.m: declare bus addresses as bus_size_t not bus_addr_t rlibby on May 21 2024, 5:04 PM. Authored by Tags None Referenced Files
Subscribers
Details Do like bus_space(9) does. This fixes the build on platforms where Fixes: c2e9c5bbf022 tpm: Refactor TIS and add a SPI attachment I don't know how to test this beyond make tinderbox. @jhibbits please feel free to take this patch over if desired.
Diff Detail
Event TimelineComment Actions The only time this makes a difference is if the sizes of bus_addr_t and bus_size_t are different, and I don't have any test hardware where that's the case and I can test TPM. (Only hardware I have where that's the case is ppc Book-E, but that doesn't have a TPM). Comment Actions Right. Not that I think this is risky, but would you like to do any testing of tpm at all before pushing to main? Otherwise I'll go ahead and push it without testing beyond make. Comment Actions No need for me to test. There's no risk for any platform Juniper uses, or my RPi I tested the original change with. Thanks for taking this! |