Page MenuHomeFreeBSD
Differential D45195

if_vxlan(4): Exclude ETHER_CRC_LEN while calculating VXLAN_MAX_MTU
ClosedPublic
Actions

Authored by zlei on May 14 2024, 4:46 AM.
Tags
None
Referenced Files
F107176127: D45195.diff
Sat, Jan 11, 6:48 AM
Unknown Object (File)
Tue, Dec 24, 3:53 PM
Unknown Object (File)
Mon, Dec 16, 5:22 PM
Unknown Object (File)
Dec 5 2024, 9:02 AM
Unknown Object (File)
Nov 1 2024, 3:19 AM
Unknown Object (File)
Sep 24 2024, 11:38 AM
Unknown Object (File)
Sep 22 2024, 7:15 AM
Unknown Object (File)
Sep 22 2024, 4:28 AM
View All 37 Files
Subscribers
ae
afedorov
glebius
imp
melifaro

Details

Reviewers
jhb
bryanv
Group Reviewers
network
Commits
rG44aca0397cc8: if_vxlan(4): Exclude ETHER_CRC_LEN from macro VXLAN_MAX_MTU
rG7de38cbb5dc4: if_vxlan(4): Exclude ETHER_CRC_LEN from macro VXLAN_MAX_MTU
rGd6963b9ed328: if_vxlan(4): Exclude ETHER_CRC_LEN from macro VXLAN_MAX_MTU
Summary

The encapsulated (original) frame does not count in FCS as per Section 5
of RFC 7348.

Fixes: b7592822d5de Allow set MTU more than 1500 bytes
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei created this revision.May 14 2024, 4:46 AM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptMay 14 2024, 4:46 AM
zlei requested review of this revision.May 14 2024, 4:46 AM
zlei added a comment.Jul 1 2024, 1:11 PM

Ping .

afedorov added a subscriber: afedorov.Jul 1 2024, 4:14 PM

As the author of the original patch about increasing MTU, I consider this change to be correct.

bryanv accepted this revision.Jul 2 2024, 1:31 AM
This revision is now accepted and ready to land.Jul 2 2024, 1:31 AM
zlei added a comment.Jul 2 2024, 4:59 AM
In D45195#1044804, @afedorov wrote:

As the author of the original patch about increasing MTU, I consider this change to be correct.

Punished you a Reviewed by: afedorov :)

Closed by commit rGd6963b9ed328: if_vxlan(4): Exclude ETHER_CRC_LEN from macro VXLAN_MAX_MTU (authored by zlei). · Explain WhyJul 2 2024, 4:59 AM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rGd6963b9ed328: if_vxlan(4): Exclude ETHER_CRC_LEN from macro VXLAN_MAX_MTU.
zlei added a commit: rG7de38cbb5dc4: if_vxlan(4): Exclude ETHER_CRC_LEN from macro VXLAN_MAX_MTU.Jul 10 2024, 10:18 AM
zlei added a commit: rG44aca0397cc8: if_vxlan(4): Exclude ETHER_CRC_LEN from macro VXLAN_MAX_MTU.Jul 10 2024, 11:45 AM

Revision Contents
Changeset List

PathSize
sys/
net/
2 lines

Diff 138518

View Options

sys/net/if_vxlan.c

Loading...