makeman: extend duplicate option warning to OPT_ options
ClosedPublic
Actions

Authored by emaste on May 13 2024, 7:28 PM.

Details

Reviewers

brooks
jhb

Commits

rG65fd76b5f566: makeman: extend duplicate option warning to OPT_ options

Summary

In a local tree I accidentally had OPT_INIT_ALL defaulting to zero in
userland and none in kernel.  This resulted in the INIT_ALL text
appearing twice in src.conf.5.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.May 13 2024, 7:28 PM

emaste created this revision.

OPT_ are not handled per-target

In my local tree:

building src.conf.5 man page from files in /home/emaste/src/freebsd-git/wipbsd/tools/build/options
...........................make[1]: "/home/emaste/src/freebsd-git/wipbsd/share/mk/bsd.mkopt.mk" line 71: warning: WITHOUT_CASPER option ignored: it is no longer supported
make[1]: "/home/emaste/src/freebsd-git/wipbsd/share/mk/bsd.mkopt.mk" line 71: warning: WITHOUT_CASPER option ignored: it is no longer supported
................................................................................................................................................................................................................................
ignoring duplicate option INIT_ALL

Seems reasonable

This revision is now accepted and ready to land.May 16 2024, 5:27 PM

Closed by commit rG65fd76b5f566: makeman: extend duplicate option warning to OPT_ options (authored by emaste). · Explain WhyMay 16 2024, 5:31 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG65fd76b5f566: makeman: extend duplicate option warning to OPT_ options.

Herald added a subscriber: imp. · View Herald TranscriptMay 16 2024, 5:31 PM