- Replace random() with arc4random().
- Change some variable types.
- Drop some unused assignments.
MFC after: 3 days
Sponsored by: Klara, Inc.
Details
Details
- Reviewers
imp markj - Group Reviewers
Klara - Commits
- rG4d09eb87c5d5: tftpd: Satisfy clang-analyzer.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 57634 Build 54522: arc lint + arc unit
Event Timeline
| libexec/tftpd/tftp-io.c | ||
|---|---|---|
| 80 | What's wrong with random() here? arc4random() is overkill for what this is doing. | |
| libexec/tftpd/tftp-io.c | ||
|---|---|---|
| 80 | Agreed, this is solely to silence make analyze. I doubt this code ever gets used anyway, the option that enables it is undocumented and the test suite doesn't even glance in its direction. | |