Page MenuHomeFreeBSD

Add options for mountd , nfsd and rpcbind
ClosedPublic

Authored by joyul_juniper.net on May 7 2024, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 2:51 AM
Unknown Object (File)
Wed, Oct 30, 4:02 PM
Unknown Object (File)
Tue, Oct 29, 3:18 PM
Unknown Object (File)
Sun, Oct 20, 5:49 PM
Unknown Object (File)
Sun, Oct 20, 4:57 PM
Unknown Object (File)
Oct 9 2024, 5:49 PM
Unknown Object (File)
Oct 4 2024, 11:09 PM
Unknown Object (File)
Oct 4 2024, 9:42 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joyul_juniper.net created this revision.

I've made some inline comments, but it looks generally ok to me.
All the man page updates require a change to the date (.Dd line)
and manpages should be asked for a group review.

Do you have a commit bit or do you want me to commit them?

usr.sbin/mountd/mountd.8
155 ↗(On Diff #138223)

I would mention that this option is meaningless
unless -h has also been used.

usr.sbin/mountd/mountd.c
523 ↗(On Diff #138223)

I'd suggest a warnx() here if (nhosts == 0 && skiplocalhost != 0)
indicating '-s" is being ignored.

usr.sbin/rpcbind/rpcbind.c
346

Although this program doesn't conform to style(9)
I would still use "nobind_localhost == 0" instead
of !nobind_localhost. I think it is more consistent
with the code around it and maybe more readable.

Thanks for taking the time to review it. Based on your feedback, I updated the patch.
And Yes, please help commit them.

In mountd.8, the capitalized flags are sorted before the lowercase flags. With those two changes, manpages LGTM

usr.sbin/mountd/mountd.8
107 ↗(On Diff #138627)

107,110m100

152 ↗(On Diff #138627)

152,158m171

This revision now requires changes to proceed.May 16 2024, 8:19 PM

Ed, maybe you can take a look at the source changes?
The man page changes have already been reviewed.
I can update those and I am willing to commit these
once you've taken a look at them.

Thanks, rick

I have made the changes suggested by Alexander Ziaee to the
man pages, although I cannot update the diff here.

I have reviewed and done some simple testing of the sources and
will start to commit these to main now. (Probably one file per commit.)

This revision was not accepted when it landed; it landed in state Needs Revision.Jul 6 2024, 8:42 PM
This revision was automatically updated to reflect the committed changes.

Hi Rick, sorry I wasn't able to look at the src changes yet, I was out for some time for summer vacation. I'm happy to take a look for post-commit review in the near future.

No problem Ed. Hope you enjoyed your vacation.
The code changes are pretty straightforward. I left
them in the style consistent with the rest of the code.
(Using "int"s instead of "bool"s for example.)

I am not sure these options are useful to others,
but I figured adding them was harmless.
That was the main question I had for you?