Page MenuHomeFreeBSD
Differential D45095

sound: Remove unused "num" argument from chn_init() and related callers
ClosedPublic
Actions

Authored by christos on May 5 2024, 4:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 9, 7:45 PM
Unknown Object (File)
Nov 19 2024, 5:36 PM
Unknown Object (File)
Nov 1 2024, 3:14 PM
Unknown Object (File)
Nov 1 2024, 1:58 PM
Unknown Object (File)
Oct 25 2024, 2:28 PM
Unknown Object (File)
Sep 14 2024, 1:43 PM
Unknown Object (File)
Sep 7 2024, 11:59 AM
Unknown Object (File)
Sep 5 2024, 10:17 AM
View All 25 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rG17a50abe0e19: sound: Remove unused "num" argument from chn_init() and related callers
rG3af2beb8b24b: sound: Remove unused "num" argument from chn_init() and related callers
Summary

It is always -1 (i.e unused).

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57588
Build 54476: arc lint + arc unit

Event Timeline

christos created this revision.May 5 2024, 4:15 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 5 2024, 4:15 PM
christos requested review of this revision.May 5 2024, 4:15 PM
Harbormaster completed remote builds in B57588: Diff 138150.May 5 2024, 4:15 PM
christos mentioned this in D44993: sound: Merge pcm_chn_create() and chn_init().May 5 2024, 4:15 PM
christos added parent revisions: D45015: sound: Move vchan-related code to pcm/vchan.*, D44993: sound: Merge pcm_chn_create() and chn_init().
dev_submerge.ch accepted this revision.May 6 2024, 4:42 PM

Looks good to me, but I cannot compile and test it. Patch doesn't apply here locally because I'm missing previous commits. Time to get that stuff merged ;-)

This revision is now accepted and ready to land.May 6 2024, 4:42 PM
Closed by commit rG3af2beb8b24b: sound: Remove unused "num" argument from chn_init() and related callers (authored by christos). · Explain WhyMay 6 2024, 6:39 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG3af2beb8b24b: sound: Remove unused "num" argument from chn_init() and related callers.
christos added a commit: rG17a50abe0e19: sound: Remove unused "num" argument from chn_init() and related callers.May 17 2024, 7:34 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
2 lines
11 lines
4 lines
4 lines
27 lines

Diff 138150

View Options

sys/dev/sound/pcm/channel.h

Loading...
View Options

sys/dev/sound/pcm/channel.c

Loading...
View Options

sys/dev/sound/pcm/sound.c

Loading...
View Options

sys/dev/sound/pcm/vchan.h

Loading...
View Options

sys/dev/sound/pcm/vchan.c

Loading...