Page MenuHomeFreeBSD

libc/tests: Fix installation without MK_TOOLCHAIN
ClosedPublic

Authored by markj on May 1 2024, 1:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 17, 12:56 AM
Unknown Object (File)
Thu, Oct 17, 12:56 AM
Unknown Object (File)
Thu, Oct 17, 12:56 AM
Unknown Object (File)
Wed, Oct 16, 11:51 PM
Unknown Object (File)
Oct 3 2024, 10:03 PM
Unknown Object (File)
Oct 3 2024, 6:03 PM
Unknown Object (File)
Oct 1 2024, 4:19 PM
Unknown Object (File)
Sep 27 2024, 2:29 PM
Subscribers

Details

Summary

There is some strange conditional logic here to avoid building a
particular test if a certain UBSAN library isn't present. This causes
build failures for me when doing an "installworld WITHOUT_TOOLCHAIN=",
which I do frequently during tests. (This failure appeared for me only
very recently, I'm not quite sure why.)

I presume the problem is that SYSROOT is unset during installworld, so
the build sees the host's copy of libclang_rt.ubsan_standalone.a and
then tries to install a binary that wasn't built during buildworld.
Assuming that this is correct, try to make the check a bit less fragile.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57481
Build 54369: arc lint + arc unit