Page MenuHomeFreeBSD

sound: Move vchan-related code to pcm/vchan.*
ClosedPublic

Authored by christos on Apr 29 2024, 5:39 PM.
Tags
None
Referenced Files
F103004800: D45015.diff
Tue, Nov 19, 5:40 PM
Unknown Object (File)
Mon, Nov 11, 12:41 AM
Unknown Object (File)
Oct 8 2024, 8:14 AM
Unknown Object (File)
Sep 25 2024, 3:42 AM
Unknown Object (File)
Sep 24 2024, 9:27 AM
Unknown Object (File)
Sep 23 2024, 2:10 PM
Unknown Object (File)
Sep 16 2024, 11:21 PM
Unknown Object (File)
Sep 15 2024, 8:13 PM
Subscribers

Details

Summary

pcm/sound.* contains code that should be part of pcm/vchan.*.

Changes:

  • pcm_setvchans() -> vchan_setnew()
  • pcm_setmaxautovchans() -> vchan_setmaxauto()
  • hw.snd.maxautovchans moved to pcm/vchan.c
  • snd_maxautovchans declaration moved to pcm/vchan.h and definition to pcm/vchan.c

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Apr 30 2024, 12:19 AM

What is this diff based on? I can't apply it on any branch I have.

What is this diff based on? I can't apply it on any branch I have.

I forgot to stack the patches, but it is diffed against the previous ones. I thought it wasn't needed, but I can diff against main and reupload if you want.

What is this diff based on? I can't apply it on any branch I have.

I forgot to stack the patches, but it is diffed against the previous ones. I thought it wasn't needed, but I can diff against main and reupload if you want.

I suppose it's fine, there's no functional changes and it compiles for you and Mark. I'm not a reviewer for all of your patches so I'll naturally miss some.