ktrace: Remove CAPFAIL from default trace points
ClosedPublic
Actions

Authored by jfree on Apr 20 2024, 5:45 PM.

Details

Reviewers

Commits

rGba501a551776: ktrace: Remove CAPFAIL from default trace points
rGf239db4800ee: ktrace: Remove CAPFAIL from default trace points

Summary

The CAPFAIL tracepoint was recently modified to report capability
violations for processes that do not enter capability mode. This
allows developers that are interested in Capsicumizing their programs
to determine where violations are being raised.

Having this tracepoint enabled by default may lead to confusion for
users that are not familiar with the feature. Remove KTRFAC_CAPFAIL from
ktrace's default points to avoid this.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jfree created this revision.Apr 20 2024, 5:45 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 20 2024, 5:45 PM

jfree requested review of this revision.Apr 20 2024, 5:45 PM

Harbormaster completed remote builds in B57248: Diff 137443.Apr 20 2024, 5:45 PM

jfree added a parent revision: D44886: ktrace: Describe CAPFAIL trace point in man page.Apr 20 2024, 5:45 PM

I would point out in the commit message that, before your commits, CAPFAIL was basically never used, so users are very unlikely to notice the change in defaults.

This revision is now accepted and ready to land.Apr 21 2024, 3:06 PM

Closed by commit rGf239db4800ee: ktrace: Remove CAPFAIL from default trace points (authored by jfree). · Explain WhyApr 24 2024, 12:29 AM

This revision was automatically updated to reflect the committed changes.

jfree added a commit: rGf239db4800ee: ktrace: Remove CAPFAIL from default trace points.

jfree added a commit: rGba501a551776: ktrace: Remove CAPFAIL from default trace points.May 12 2024, 12:09 AM