Page MenuHomeFreeBSD

Fix build with WITH_NVME newly enabled
ClosedPublic

Authored by brooks on Apr 17 2024, 11:53 PM.
Tags
None
Referenced Files
F96487829: D44826.diff
Wed, Sep 25, 4:33 AM
F96323829: D44826.id137271.diff
Tue, Sep 24, 2:39 PM
Unknown Object (File)
Sat, Sep 21, 5:50 AM
Unknown Object (File)
Thu, Sep 19, 5:19 AM
Unknown Object (File)
Thu, Sep 19, 1:37 AM
Unknown Object (File)
Wed, Sep 18, 11:10 PM
Unknown Object (File)
Wed, Sep 18, 1:31 PM
Unknown Object (File)
Wed, Sep 18, 9:50 AM
Subscribers
None

Details

Summary

rescue.mk doesn't get updated when options change so nvme_util.o is now
missing on architectures were NVME was previously marked BROKEN.

Fixes: 2fda3ab0ac19 WITH_NVME: Remove from broken.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.

This is slightly too big of a hammer in that rescue.mk will also be regenerated if WITHOUT_NVME is set, but if it's on the way out that seems fine.

oh! That's the problem... I did a clean build and that's why I didn't see it...

Also, maybe we should regenerate it when certain options change...

This revision is now accepted and ready to land.Apr 18 2024, 3:49 AM