Page MenuHomeFreeBSD

Fix build with WITH_NVME newly enabled
ClosedPublic

Authored by brooks on Apr 17 2024, 11:53 PM.
Tags
None
Referenced Files
F115628202: D44826.diff
Sat, Apr 26, 5:45 AM
F115615157: D44826.diff
Sat, Apr 26, 1:03 AM
Unknown Object (File)
Fri, Apr 25, 3:17 PM
Unknown Object (File)
Mar 7 2025, 5:58 PM
Unknown Object (File)
Feb 26 2025, 4:41 PM
Unknown Object (File)
Feb 22 2025, 2:30 PM
Unknown Object (File)
Feb 22 2025, 1:38 PM
Unknown Object (File)
Feb 22 2025, 1:28 PM
Subscribers
None

Details

Summary

rescue.mk doesn't get updated when options change so nvme_util.o is now
missing on architectures were NVME was previously marked BROKEN.

Fixes: 2fda3ab0ac19 WITH_NVME: Remove from broken.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.

This is slightly too big of a hammer in that rescue.mk will also be regenerated if WITHOUT_NVME is set, but if it's on the way out that seems fine.

oh! That's the problem... I did a clean build and that's why I didn't see it...

Also, maybe we should regenerate it when certain options change...

This revision is now accepted and ready to land.Apr 18 2024, 3:49 AM