Differential D44685

tcp: Make tcp_var.h more self-contained
ClosedPublic
Actions

Authored by markj on Apr 8 2024, 5:40 PM.

Details

Reviewers

glebius

Group Reviewers

transport

Commits

rGca8e2e4c91cc: tcp: Make tcp_var.h more self-contained
rG1d14e88e5332: tcp: Make tcp_var.h more self-contained

Summary

struct tcpcb embeds a struct osd and a struct callout. Rather than
forcing all consumers to pull in the same
headers, include the headers directly.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 56967
Build 53855: arc lint + arc unit

Event Timeline

markj created this revision.Apr 8 2024, 5:40 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptApr 8 2024, 5:40 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

markj requested review of this revision.Apr 8 2024, 5:40 PM

Harbormaster completed remote builds in B56967: Diff 136693.Apr 8 2024, 5:40 PM

There is a guard at line 88:

#if defined(_KERNEL) || defined(_WANT_TCPCB)

Maybe move the includes there, just next to netinet/cc/cc.h?
What's the final goal of the change?

Include headers only when needed.

Harbormaster completed remote builds in B56985: Diff 136769.Apr 9 2024, 1:05 PM

markj edited the summary of this revision. (Show Details)Apr 9 2024, 1:05 PM

In D44685#1018957, @glebius wrote:
There is a guard at line 88:
#if defined(_KERNEL) || defined(_WANT_TCPCB)
Maybe move the includes there, just next to netinet/cc/cc.h?

Thanks, I missed that. Done.

What's the final goal of the change?

In general we've been trying to make kernel headers self-contained when possible. In my case I found some bits in net-snmp which do not compile because these includes are missing.

I'm fine with this change, but I really prefer net-snmp not to know anything about struct tcpcb. I'll take a look at it later.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2024, 12:54 PM

Closed by commit rG1d14e88e5332: tcp: Make tcp_var.h more self-contained (authored by markj). · Explain Why

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG1d14e88e5332: tcp: Make tcp_var.h more self-contained.

markj added a commit: rGca8e2e4c91cc: tcp: Make tcp_var.h more self-contained.Apr 17 2024, 2:35 PM