Page MenuHomeFreeBSD
Differential D44667

vm_reserv_reclaim_contig: Return NULL not false
ClosedPublic
Actions

Authored by minsoochoo0122_proton.me on Apr 7 2024, 5:44 AM.
Tags
Referenced Files
Unknown Object (File)
Sat, Jan 25, 4:05 AM
Unknown Object (File)
Fri, Jan 24, 5:56 PM
Unknown Object (File)
Wed, Jan 22, 11:18 PM
Unknown Object (File)
Tue, Jan 21, 8:53 PM
Unknown Object (File)
Sun, Jan 5, 7:33 PM
Unknown Object (File)
Dec 4 2024, 10:52 AM
Unknown Object (File)
Nov 17 2024, 9:12 PM
Unknown Object (File)
Nov 17 2024, 8:35 PM
View All 44 Files
Subscribers
imp
zlei
Contributor Reviews (src)

Details

Reviewers
markj
zlei
dougm
Group Reviewers
Contributor Reviews (src)
Commits
rG1f85f062768d: vm_reserv_reclaim_contig: Return NULL not false
rG989a2cf19d05: vm_reserv_reclaim_contig: Return NULL not false
Summary

Since vm_page_t is a typedef of a pointer to struct vm_page, returning
false is undefined.

Test Plan

make buildkernel

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 56953
Build 53841: arc lint + arc unit

Event Timeline

minsoochoo0122_proton.me created this revision.Apr 7 2024, 5:44 AM
Herald added a subscriber: imp. · View Herald TranscriptApr 7 2024, 5:44 AM
minsoochoo0122_proton.me requested review of this revision.Apr 7 2024, 5:44 AM
Harbormaster completed remote builds in B56953: Diff 136640.Apr 7 2024, 5:44 AM
minsoochoo0122_proton.me edited the test plan for this revision. (Show Details)Apr 7 2024, 5:45 AM
minsoochoo0122_proton.me added a reviewer: Contributor Reviews (src).
minsoochoo0122_proton.me added a project: Contributor Reviews (src).
minsoochoo0122_proton.me added a subscriber: Contributor Reviews (src).
minsoochoo0122_proton.me added a comment.Apr 7 2024, 5:49 AM

I'm not completely familar with FreeBSD's virtual memory system. But it seems the comment still doesn't match the code. Doesn't it return m_ret when the reclaim is successful and null when failed?

lwhsu added a reviewer: markj.Apr 7 2024, 6:10 AM
zlei accepted this revision.Apr 10 2024, 8:56 AM
zlei added a subscriber: zlei.

Looks good to me.

sys/vm/vm_reserv.c
1195

English is not my tone but it sounds 'or' is more appropriate.

1197

The return type was changed from bool to vm_page_t by commit 0d5fac287294 (vm: alloc pages from reserv before breaking it) but the comments are left unchanged.

This revision is now accepted and ready to land.Apr 10 2024, 8:56 AM
zlei added a reviewer: dougm.Apr 10 2024, 9:11 AM
dougm accepted this revision.Apr 10 2024, 9:40 AM
Closed by commit rG989a2cf19d05: vm_reserv_reclaim_contig: Return NULL not false (authored by minsoochoo0122_proton.me, committed by markj). · Explain WhyApr 10 2024, 12:52 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG989a2cf19d05: vm_reserv_reclaim_contig: Return NULL not false.
markj added a commit: rG1f85f062768d: vm_reserv_reclaim_contig: Return NULL not false.Apr 17 2024, 2:35 PM

Revision Contents
Changeset List

PathSize
sys/
vm/
4 lines

Diff 136640

View Options

sys/vm/vm_reserv.c

Loading...