Page MenuHomeFreeBSD
Differential D44654

nvmecontrol: Move self test status page printing to little endian orderinng
ClosedPublic
Actions

Authored by imp on Apr 6 2024, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 7:28 AM
Unknown Object (File)
Sun, Jan 26, 6:04 PM
Unknown Object (File)
Thu, Jan 23, 6:44 AM
Unknown Object (File)
Mon, Jan 13, 9:19 PM
Unknown Object (File)
Dec 13 2024, 7:41 AM
Unknown Object (File)
Dec 5 2024, 5:39 PM
Unknown Object (File)
Nov 19 2024, 3:17 PM
Unknown Object (File)
Nov 15 2024, 1:06 AM
View All 48 Files
Subscribers
dab

Details

Reviewers
jhb
chuck
mav
Commits
rG067abd7d0b06: nvmecontrol: Move self test status page printing to little endian orderinng
rG98f841efd8ce: nvmecontrol: Move self test status page printing to little endian orderinng
Summary

Also, add printing vnedor_specific field, which doesn't have a valid
bit, so is always valid.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 56938
Build 53826: arc lint + arc unit

Event Timeline

imp created this revision.Apr 6 2024, 6:56 PM
Herald added a subscriber: dab. · View Herald TranscriptApr 6 2024, 6:56 PM
imp requested review of this revision.Apr 6 2024, 6:56 PM
Harbormaster completed remote builds in B56938: Diff 136617.Apr 6 2024, 6:56 PM
imp added a parent revision: D44653: nvmecontrol: Move namespace change page printing to little endian orderinng.Apr 6 2024, 6:56 PM
imp added a child revision: D44655: nvmecontrol: Move command effeccts page printing to little endian orderinng.
chuck accepted this revision.Apr 8 2024, 3:10 PM
chuck added inline comments.
sbin/nvmecontrol/logpage.c
593

Probably wrap this with LE2H() for consistency

635

Shouldn't the if expressions wrap valid_diag_info to be consistent? Here and below.

This revision is now accepted and ready to land.Apr 8 2024, 3:10 PM
imp updated this revision to Diff 136686.Apr 8 2024, 4:57 PM

Fix based on review feedback

This revision now requires review to proceed.Apr 8 2024, 4:57 PM
Harbormaster completed remote builds in B56961: Diff 136686.Apr 8 2024, 4:57 PM
chuck accepted this revision.Apr 8 2024, 5:06 PM
This revision is now accepted and ready to land.Apr 8 2024, 5:06 PM
Closed by commit rG98f841efd8ce: nvmecontrol: Move self test status page printing to little endian orderinng (authored by imp). · Explain WhyApr 17 2024, 3:34 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG98f841efd8ce: nvmecontrol: Move self test status page printing to little endian orderinng.
jhb added a commit: rG067abd7d0b06: nvmecontrol: Move self test status page printing to little endian orderinng.Aug 27 2024, 1:07 AM

Revision Contents
Changeset List

PathSize
sbin/
nvmecontrol/
31 lines

Diff 136617

View Options

sbin/nvmecontrol/logpage.c

Loading...