Page MenuHomeFreeBSD

sockets: Add hhook in sonewconn for inheriting OSD specific data
ClosedPublic

Authored by stevek on Apr 4 2024, 12:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 5:04 AM
Unknown Object (File)
Sun, Mar 16, 2:19 AM
Unknown Object (File)
Mon, Mar 10, 1:47 PM
Unknown Object (File)
Mon, Mar 10, 11:12 AM
Unknown Object (File)
Jan 26 2025, 3:52 PM
Unknown Object (File)
Jan 26 2025, 3:36 PM
Unknown Object (File)
Jan 19 2025, 3:54 PM
Unknown Object (File)
Jan 14 2025, 2:37 AM
Subscribers

Details

Summary

Added HHOOK_SOCKET_NEWCONN and bumped HHOOK_SOCKET_LAST

Obtained from: Juniper Networks, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I was about to ask "where is #ifdef TCP_HHOOKS?" But then I realized that socket_hhh isn't hidden under any ifdef.

Unrelated to this review, but may I ask if it is possible to hide socket_hhh and other stuff that came in 4ec7371233268 under TCP_HHOOKS? Or maybe SOCKET_HHOOKS, if these two are used as two independent features.

This revision is now accepted and ready to land.Apr 4 2024, 3:47 AM

I was about to ask "where is #ifdef TCP_HHOOKS?" But then I realized that socket_hhh isn't hidden under any ifdef.

Unrelated to this review, but may I ask if it is possible to hide socket_hhh and other stuff that came in 4ec7371233268 under TCP_HHOOKS? Or maybe SOCKET_HHOOKS, if these two are used as two independent features.

I like the idea to put it under an #ifdef.

I was about to ask "where is #ifdef TCP_HHOOKS?" But then I realized that socket_hhh isn't hidden under any ifdef.

Unrelated to this review, but may I ask if it is possible to hide socket_hhh and other stuff that came in 4ec7371233268 under TCP_HHOOKS? Or maybe SOCKET_HHOOKS, if these two are used as two independent features.

I think it should be possibly. I'll look at doing the changes to add option handling to the code.