Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 56891 Build 53779: arc lint + arc unit
Event Timeline
Should we mention something about ZFS here? I guess there should be a high-level section on ZFS/NFS that has a xref to wherever the sharenfs property is documented, and we could have an internal reference to tat section from the "Note well" text.
For now, perhaps something along the lines of "Note that this is inherently true when exporting a ZFS dataset via the 'sharenfs' propertly."?
(Do we have something like Klara's https://klarasystems.com/articles/nfs-shares-with-zfs/ in a man page or the Handbook?)
Annoyingly, the documentation for sharenfs in zfsprops is a bit Linux-specific. I'll submit a patch for that.
For now, perhaps something along the lines of "Note that this is inherently true when exporting a ZFS dataset via the 'sharenfs' propertly."?
That seems reasonable.
It's a bit terse, but: https://docs.freebsd.org/en/books/handbook/zfs/#zfs-zfs-set-share
It's a bit terse, but: https://docs.freebsd.org/en/books/handbook/zfs/#zfs-zfs-set-share
Ah, thanks - seems to approach from the wrong side (these properties control nfs sharing rather than to nfs share zfs datasets, set this) but at least it's there
I made a couple of comments, but feel free to ignore
them, since I think the patch is fine without the changes.
usr.sbin/mountd/exports.5 | ||
---|---|---|
74 | Although currently true, "local" is not required in general. Saying "non-NFS file system mount point" is technically | |
80 | I might not say "separate" here and instead use the "file system" mantra. |
usr.sbin/mountd/exports.5 | ||
---|---|---|
74 | I'd somewhat prefer to keep it the way it is: the man page uses "local" this way in several places, and I think the use of "local" is meant to distinguish from exported file systems, as opposed to local in the sense of MNT_LOCAL, which I think is what you mean? |