tarfs: Support paths that spill into exthdrs.
ClosedPublic
Actions

Authored by des on Apr 2 2024, 8:15 PM.

Details

Reviewers

sjg
kevans

Group Reviewers

Klara

Commits

rG59c3e7a18c7c: tarfs: Support paths that spill into exthdrs.
rGb1fd95c9e247: tarfs: Support paths that spill into exthdrs.

Summary

MFC after: 3 days
Sponsored by: Juniper Networks, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Apr 2 2024, 8:15 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 2 2024, 8:15 PM

des requested review of this revision.Apr 2 2024, 8:15 PM

Harbormaster completed remote builds in B56875: Diff 136449.Apr 2 2024, 8:15 PM

des added a child revision: D44600: tarfs: Ignore global extended headers..Apr 2 2024, 8:15 PM

des added a subscriber: nonesuch_longcount.org.Apr 2 2024, 8:26 PM

kevans accepted this revision.Apr 3 2024, 4:48 AM

kevans added a subscriber: kevans.

kevans added inline comments.

sys/fs/tarfs/tarfs_vfsops.c
619	Is there any value in complaining if we somehow see both a path and GNU.sparse.name exthdr?

This revision is now accepted and ready to land.Apr 3 2024, 4:48 AM

des marked an inline comment as done.Apr 3 2024, 9:14 AM

des added inline comments.

sys/fs/tarfs/tarfs_vfsops.c
619	I don't think so. I don't see how it can be exploited. We'll just use whichever came last, we won't leak memory or take a wrong turn somewhere.

des marked an inline comment as done.Apr 3 2024, 9:14 AM

Closed by commit rGb1fd95c9e247: tarfs: Support paths that spill into exthdrs. (authored by des). · Explain WhyApr 3 2024, 10:00 AM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGb1fd95c9e247: tarfs: Support paths that spill into exthdrs..

des added a commit: rG59c3e7a18c7c: tarfs: Support paths that spill into exthdrs..Apr 8 2024, 10:11 AM

Revision Contents
Changeset List

Path

Size

sys/

fs/

tarfs/

tarfs_vfsops.c

7 lines

tests/

sys/

fs/

tarfs/

tarfs_test.sh

50 lines

Diff 136470

View Options

sys/fs/tarfs/tarfs_vfsops.c